SDK - Got rid of the global variable collecting all created pipelines #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
SDK---Got-rid-of-the-global-variable-collecting-all-pipelines-ever-created
branch
from
c68dd47 to
5313bfd
Compare
This list was only used by the command-line compiler. The command-line compiler can still collect the created pipelines by registering a handler function in `_pipeline_decorator_handlers`.
Ark-kun
force-pushed
the
SDK---Got-rid-of-the-global-variable-collecting-all-pipelines-ever-created
branch
from
5313bfd to
91cfeb0
Compare
gaoning777
reviewed
Apr 17, 2019
gaoning777
reviewed
Apr 17, 2019
gaoning777
reviewed
Apr 17, 2019
gaoning777
reviewed
Apr 17, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK---Got-rid-of-the-global-variable-collecting-all-pipelines-ever-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list was only used by the command-line compiler.
The command-line compiler can still collect the created pipelines by registering a handler function in
_pipeline_decorator_handlers.This change is