Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arena component with git support #1179

Merged
merged 7 commits into from
Apr 19, 2019
Merged

Update arena component with git support #1179

merged 7 commits into from
Apr 19, 2019

Conversation

cheyang
Copy link
Contributor

@cheyang cheyang commented Apr 17, 2019 •
edited by jlewi
Loading

This change is Reviewable

@cheyang cheyang changed the title Update standalone sample with git support Update arena component with git support Apr 18, 2019
@cheyang
Copy link
Contributor Author

cheyang commented Apr 18, 2019

/retest

1 similar comment
@cheyang
Copy link
Contributor Author

cheyang commented Apr 18, 2019

/retest

@cheyang
Copy link
Contributor Author

cheyang commented Apr 18, 2019

@Ark-kun , I've updated according to your suggestions. PTAL.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 18, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Contributor Author

cheyang commented Apr 19, 2019

@Ark-kun Thanks.

@k8s-ci-robot k8s-ci-robot merged commit 2eddf0e into kubeflow:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@Ark-kun Ark-kun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheyang @Ark-kun @k8s-ci-robot