Close the streams after getting gcloud auth token #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error message saw in some cases
```
/tmpfs/BUILD_ENV/lib/python3.5/site-packages/kfp/_auth.py:34: ResourceWarning: unclosed file <_io.TextIOWrapper name=6 encoding='UTF-8'>
return os.popen('gcloud auth print-access-token').read().rstrip()
```
|
/assign @Ark-kun @hongye-sun |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
Ark-kun
changed the title
|
/cc @jlewi |
|
@Ark-kun Was there something particular you wanted me to look at? /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
only the postsubmit tests are failing. |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
ModelMesh needs specific fields to convey predictor status information. This commit introduces a new ModelStatus object to contain these fields. Signed-off-by: Paul Van Eck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message saw in some cases
This change is