Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Make links in pipeline description clickable #2376

Merged
merged 16 commits into from
Oct 21, 2019
Merged

[Frontend] Make links in pipeline description clickable #2376

merged 16 commits into from
Oct 21, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 12, 2019 •
edited
Loading

Improves usability of pipeline description.

demo: https://drive.google.com/file/d/1Z-W6yeIQNVxXF1J0KwKcY1UDPVR_8Tmo/view
new demo (changed implementation to markdown link):
localhost_3000_ (2)

Changes:

  • Pipeline list description is rendered as inline markdown
  • Pipeline detail description is rendered as normal markdown
  • Updated markdown viewer to also use react-to-jsx because it is smaller in bundle size and better integrated with react. (It doesn't quite make sense we use two markdown parsers.)
  • Updated sample README using new markdown syntax for links

/area front-end
/kind feature
/cc @jessiezcc

This change is Reviewable

@Bobgy Bobgy mentioned this pull request Oct 12, 2019
Closed
@Bobgy Bobgy changed the title [Frontend] Make links in pipeline description clickable [WIP] [Frontend] Make links in pipeline description clickable Oct 12, 2019
Bobgy added 2 commits October 16, 2019 13:32
@Bobgy
Merge remote-tracking branch 'official/master' into fe_links_in_pipel…
0f9e1aa 
…ine_description
@Bobgy
Change the implementation to allow markdown rendering of pipeline des…
a0699ad 
…cription. Use inline format when in pipeline list page, and normal format in detail page.
@Bobgy Bobgy changed the title [WIP] [Frontend] Make links in pipeline description clickable [Frontend] Make links in pipeline description clickable Oct 16, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 16, 2019

@jessiezcc and @gaoning777, I updated demo screenshot (its data is purely faked to show utility).
Do you have any further suggestions on the wording?

Changes:

  1. This now uses markdown url syntax.
  2. Updated sample description to put permission requirements at first word.

@gaoning777
Copy link
Contributor

@jessiezcc and @gaoning777, I updated demo screenshot (its data is purely faked to show utility).
Do you have any further suggestions on the wording?

Changes:

  1. This now uses markdown url syntax.
  2. Updated sample description to put permission requirements at first word.

This is great. BTW, is the link fonts color rendered as purple because it's been clicked? Normally links are blue.

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 17, 2019

This is great. BTW, is the link fonts color rendered as purple because it's been clicked? Normally links are blue.

Yes, it's been clicked

@gaoning777
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 17, 2019

/assign @jessiezcc

@gaoning777
Copy link
Contributor

/lgtm

@numerology
Copy link

numerology commented Oct 17, 2019 •
edited
Loading

Thanks for doing this! @Bobgy

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 18, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 18, 2019

/approve
for frontend part

@IronPan Can you approve for backend?

@numerology
Copy link

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 21, 2019 •
edited
Loading

Made some minor styling changes:

  1. Use our theme color
  2. Hide underline initially and show it on hover

demo: https://drive.google.com/file/d/1TVXJovghgUOTSQIO8vBkqo6LVOEhAC6H/view

@IronPan
Copy link
Member

IronPan commented Oct 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7b918bc into kubeflow:master Oct 21, 2019
@Bobgy Bobgy deleted the fe_links_in_pipeline_description branch October 25, 2019 00:56
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@andyi2it @yuzisun
Fix failure to create gRPC isvc when specifying multiple ContainerPor…
a4e5a25 
…ts (kubeflow#2464)

* Fix failure to create gRPC isvc when specifying multiple ContainerPorts (kubeflow#2376)

Signed-off-by: Andrews Arokiam <[email protected]>

* Update reconciler to add just svc
Add grpc test for raw deployment

Signed-off-by: Andrews Arokiam <[email protected]>

* Fix linting errors in test code

Signed-off-by: Andrews Arokiam <[email protected]>

* Minor code improvements

Signed-off-by: Dan Sun <[email protected]>

Signed-off-by: Andrews Arokiam <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@jessiezcc jessiezcc jessiezcc left review comments

Assignees

@IronPan IronPan

@gaoning777 gaoning777

@jessiezcc jessiezcc

Labels
approved area/frontend kind/feature lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bobgy @gaoning777 @numerology @IronPan @k8s-ci-robot @jessiezcc