Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech writer edits #2403

Merged
merged 4 commits into from
Oct 17, 2019
Merged

tech writer edits #2403

merged 4 commits into from
Oct 17, 2019

Conversation

jay-saldanha
Copy link
Contributor

@jay-saldanha jay-saldanha commented Oct 16, 2019

@hongye-sun please merge the file after your edits


This change is Reviewable

@hongye-sun please merge the file after your edits
@k8s-ci-robot
Copy link
Contributor

Hi @jay-saldanha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor Author

@jay-saldanha jay-saldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongye-sun pls address the comments here

# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
<!--is this licenese required here, no other compnenet has the license here, i think we can remove it-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this license can be removed from here, it is not there in any other components

more detailed examples that introduce additional concepts.

#### A minimalist word-counting workflow that counts words in Shakespeare
This is the first in a series of successively more detailed word count examples. Next, see the wordcount pipeline, then the wordcount_debugging pipeline, for more detailed examples that introduce additional concepts. <!--where should the user find this examples, can we give a link to these?-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can users find the word count pipeline and wordcount debugging pipeline? is there a link to these?

@hongye-sun
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac34438 into kubeflow:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants