Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize samples/core/tfx-oss Notebook #2618

Merged
merged 6 commits into from
Nov 19, 2019

Conversation

ucdmkt
Copy link
Contributor

@ucdmkt ucdmkt commented Nov 16, 2019

Per feedback from @ultrons, also #2169, updating samples/core/tfx-oss notebook to be most-up-to-date demonstration of the pipeline.

Also removing metadata inspection demonstration as metadata_config is assuming obsolete deployment configurations, and there is no longer a consistent metadata_config applicable from inside- and outside- the cluster.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @ucdmkt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaoning777
Copy link
Contributor

/ok-to-test

@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d72f435 into kubeflow:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants