Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Community] Improve BUG_REPORT.md #3081

Merged
merged 3 commits into from
Feb 15, 2020
Merged

[Community] Improve BUG_REPORT.md #3081

merged 3 commits into from
Feb 15, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 14, 2020 •
edited
Loading

Changes:

  1. add /kind bug label for reporter
  2. adjust steps section to first section, because I think natural mental order is describing what they did to reproduce the bug, then describe result and expected result

Update:

  1. Added a section to let users tell their environment (versions)
  2. Added area labels to let users assign areas by themselves

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 14, 2020

/retest

@numerology
Copy link

/lgtm

numerology
numerology reviewed Feb 14, 2020
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 14, 2020
@numerology
Copy link

/lgtm

@IronPan
Copy link
Member

IronPan commented Feb 15, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 231db91 into master Feb 15, 2020
@Bobgy Bobgy deleted the Bobgy-patch-1 branch February 16, 2020 05:47
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Bobgy @Jeffwan
[Community] Improve BUG_REPORT.md (kubeflow#3081)
9bc9977 
* [Community] Improve BUG_REPORT.md

* Update BUG_REPORT.md

* Apply suggestions from code review

Co-Authored-By: Jiaxiao Zheng <[email protected]>

Co-authored-by: Jiaxiao Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@numerology numerology

Labels
approved area/docs lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobgy @numerology @IronPan @k8s-ci-robot