-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): upgrade argo go module to V3. Part of #5718 #5792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have major feedback now, will review in details again.
Thank you so much for taking this upgrade!
niklastest/test.py
Outdated
import kfp as kfp | ||
|
||
@kfp.components.func_to_container_op | ||
def print_func(param: str): | ||
print(str(param)) | ||
return | ||
|
||
@kfp.dsl.pipeline(name='pipeline') | ||
def pipeline(param: str): | ||
print_func(param) | ||
return | ||
|
||
if __name__ == '__main__': | ||
kfp.compiler.Compiler().compile(pipeline, __file__ + ".zip") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up?
/lgtm We need to validate the upgrade, and it seems the best way is to merge, publish a prerelease and verify. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I updated wording to |
To make is clear(realised that it might not have been), we will have to upgrade again when 3.1 is release but that should be a very small update @Bobgy. |
No worries, I totally understand that, and it's great to upgrade in smaller steps, so each upgrade is easier. |
Description of your changes:
Part of #5718
Checklist: