Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): upgrade argo go module to V3. Part of #5718 #5792

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

NikeNano
Copy link
Member

@NikeNano NikeNano commented Jun 3, 2021

Description of your changes:

Part of #5718

Checklist:

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have major feedback now, will review in details again.

Thank you so much for taking this upgrade!

Comment on lines 1 to 14
import kfp as kfp

@kfp.components.func_to_container_op
def print_func(param: str):
print(str(param))
return

@kfp.dsl.pipeline(name='pipeline')
def pipeline(param: str):
print_func(param)
return

if __name__ == '__main__':
kfp.compiler.Compiler().compile(pipeline, __file__ + ".zip")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up?

@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

/lgtm
/approve
Thank you so much for the upgrade! I can clearly see it was quite some work and really valuable to everyone!

We need to validate the upgrade, and it seems the best way is to merge, publish a prerelease and verify.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title feat(backend): upgrade argo to V3. Fixes #5718, feat(backend): upgrade argo to V3. Fixes #5718 Jun 8, 2021
@Bobgy Bobgy changed the title feat(backend): upgrade argo to V3. Fixes #5718 feat(backend): upgrade argo go module to V3. Part of #5718 Jun 8, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

I updated wording to part of #5718, because we still need to upgrade argo images.
I'll complete the license review and push related images.

@google-oss-robot google-oss-robot merged commit 00a0ffb into kubeflow:master Jun 8, 2021
@NikeNano
Copy link
Member Author

NikeNano commented Jun 8, 2021

To make is clear(realised that it might not have been), we will have to upgrade again when 3.1 is release but that should be a very small update @Bobgy.

@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

No worries, I totally understand that, and it's great to upgrade in smaller steps, so each upgrade is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants