-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use argo emissary executor by default. Fixes #5718 #5926
Conversation
/retest |
/retest |
2 similar comments
/retest |
/retest |
Current blocker: the non-root pod's main container successfully executed and finished, but the wait container did not terminate.
|
/retest |
The remaining problem is that the sidecar.py sample is not ending.
|
/retest |
/test kubeflow-pipeline-mkp-test |
/approve |
Merging early to prepare for RC release |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we should start warning the users that they need to always set |
After more discussion, because emissary is still Alpha in argo. |
Description of your changes:
Fixes #5718
Breaking change
Argo emissary executor requires that each container has explicit command and args defined, refer to https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary.
Why we decide to adopt the breaking change? We'd have the same breaking change in bit.ly/kfp-v2-compatible and bit.ly/kfp-v2. So I think it aligns with KFP's long term goal, and it's OK to introduce the breaking change now.
Checklist: