Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use argo emissary executor by default. Fixes #5718 #5926

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 28, 2021

Description of your changes:
Fixes #5718

Breaking change

Argo emissary executor requires that each container has explicit command and args defined, refer to https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary.

Why we decide to adopt the breaking change? We'd have the same breaking change in bit.ly/kfp-v2-compatible and bit.ly/kfp-v2. So I think it aligns with KFP's long term goal, and it's OK to introduce the breaking change now.

Checklist:

@google-cla google-cla bot added the cla: yes label Jun 28, 2021
@Bobgy Bobgy changed the title feat!: use argo emissary executor by default feat!: use argo emissary executor by default. Fixes #5718 Jun 28, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 30, 2021

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 14, 2021

/retest

2 similar comments
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 15, 2021

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 15, 2021

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 15, 2021

Current blocker:

the non-root pod's main container successfully executed and finished, but the wait container did not terminate.

2021-07-15 15:39:08.000 HKT main container
+ exit 0
2021-07-15 15:42:31.136 HKT wait container
time="2021-07-15T07:42:31.135Z" level=info msg="Alloc=4053 TotalAlloc=9145 Sys=73809 NumGC=5 Goroutines=8"
2021-07-15 15:47:31.136 HKT wait container
time="2021-07-15T07:47:31.135Z" level=info msg="Alloc=4075 TotalAlloc=9253 Sys=73809 NumGC=7 Goroutines=8"

https://storage.googleapis.com/oss-prow/pr-logs/pull/kubeflow_pipelines/5926/kubeflow-pipeline-e2e-test/1415563732758564864/artifacts/pods_info/integration-test-vwp75-1409706194.txt

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 20, 2021

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 21, 2021

The remaining problem is that the sidecar.py sample is not ending.
I found logs from the sidecar container:

2021/07/21 11:30:04 [ERR] Unknown signal terminated
2021/07/21 11:30:04 [ERR] Unknown signal urgent I/O condition
2021/07/21 11:30:08 [ERR] Unknown signal urgent I/O condition

https://storage.googleapis.com/oss-prow/pr-logs/pull/kubeflow_pipelines/5926/kubeflow-pipeline-sample-test/1417793963884023808/artifacts/pods_info/pipeline-with-sidecar-bl64j-3037665903.txt

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/test kubeflow-pipeline-mkp-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/approve

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

Merging early to prepare for RC release

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 0c4129c into kubeflow:master Jul 22, 2021
@Bobgy Bobgy deleted the emissary branch July 22, 2021 12:09
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 22, 2021

I think we should start warning the users that they need to always set command: #4800

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 29, 2021

After more discussion, because emissary is still Alpha in argo.
I'll propose to change it to the default in a later release and ask for more feedback for trying it out in the next KFP community meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] default to the emissary executor
3 participants