Expose that the python API is Python3.5+ only #616
Conversation
Adding these classifiers (many are the same as e.g. TensorFlow) makes sure pip/pypi index pick these up as being 3.5+ only, so that developers on Python 2 are not suprised when it fails on Python 3 syntax (e.g. typehints are only py 3.5+).
|
Hi @TimZaman. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @TimZaman. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think we're actually Python 3.6+ only. @qimingj @gaoning777 @Ark-kun |
|
Thanks @yebrahim , reflected that in change. Tested 3.7 to work too. |
|
Yup, >= 3.6. I'll let @qimingj or @gaoning777 take a look first though. Thanks @TimZaman. |
|
@qimingj done, should be g2g. (Even if 3.5 doesn't work, at least with this MR we won't be bothering Python2 users with them reeling in a python3 package.) |
I thought we were 3.5+. 3.6+ is much better for me (variable typing). |
|
We should probably just use |
|
That's fairly new, so we should do both:
|
|
/ok-to-test |
|
I think this one is g2g |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Expose that the python API is Python3.5+ only Adding these classifiers (many are the same as e.g. TensorFlow) makes sure pip/pypi index pick these up as being 3.5+ only, so that developers on Python 2 are not suprised when it fails on Python 3 syntax (e.g. typehints are only py 3.5+). * Update setup.py * Update setup.py * Update setup.py
* There was a syntax error so we weren't GC'ing deployments Fix: kubeflow#616
* Export LoggerRequest, Fix local logger README * Update B to Bytes in Logger struct
* Update README.md * Update README.md
Adding these classifiers (many are the same as e.g. TensorFlow) makes sure pip/pypi index pick these up as being 3.5+ only, so that developers on Python 2 are not suprised when it fails on Python 3 syntax (e.g. typehints are only py 3.5+).
This change is