Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): mock-backend didn't understand absolute path import in frontend/src/. Fix #6212 #6213

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Aug 2, 2021

Description of your changes:
Fix #6212

mock-backend build rule fails with error: internal link: http://gpaste/6208061350871040

Because of TypeStrong/ts-node#138, we cannot use absolute path import in src/ unless we use this library: https://www.npmjs.com/package/tsconfig-paths.

Another way is to change all imports to relative paths, but that is less optimal.

Checklist:

@Bobgy
Copy link
Contributor

Bobgy commented Aug 2, 2021

/lgtm
Looks great

@zijianjoy
Copy link
Collaborator Author

Thank you Yuan!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 4804034 into kubeflow:master Aug 3, 2021
@Bobgy Bobgy deleted the fixmockbackend branch August 4, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mock-backend unable to resolve paths in tsconfig when running ts-node.
3 participants