Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resnet-cmle sample back. Update all component images. #632

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Add resnet-cmle sample back. Update all component images. #632

merged 3 commits into from
Jan 7, 2019

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Jan 4, 2019 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from Ark-kun, gaoning777 and hongye-sun and removed request for Ark-kun January 4, 2019 23:04
@qimingj
Copy link
Contributor Author

qimingj commented Jan 5, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor

Add a sample test for the resnet?

@qimingj
Copy link
Contributor Author

qimingj commented Jan 5, 2019

I do plan to but this one takes much longer time so we need to do some parameter tuning, and perhaps data sampling. Plan to do it in a separate change.

gaoning777
gaoning777 approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm.
We need to make sure the published samples run correctly.
And, we can add automatic sample tests in another PR.

@qimingj
Copy link
Contributor Author

qimingj commented Jan 7, 2019

Yes. The sample test will come soon. For some reasons your /lgtm was not picked up (maybe because the extra ".")?

@gaoning777
Copy link
Contributor

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Jan 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8b6e37 into kubeflow:master Jan 7, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@clarketm
Fix casing for GitHub references (kubeflow#632)
63b8191
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Update Github Action PR trigger (kubeflow#632)
f76951e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qimingj @gaoning777 @k8s-ci-robot