Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Added _naming._convert_to_human_name function #715

Merged
merged 2 commits into from
Jan 25, 2019
Merged

SDK/Components - Added _naming._convert_to_human_name function #715

merged 2 commits into from
Jan 25, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 21, 2019 •
edited by jlewi
Loading

/assign @qimingj @gaoning777 @hongye-sun

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 22, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

/test kubeflow-pipeline-build-image

qimingj
qimingj approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@qimingj qimingj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Nice move. It would also be nice to add a few unit tests since they are grouped together now. Could be a separate change.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

/lgtm
Nice move. It would also be nice to add a few unit tests since they are grouped together now. Could be a separate change.

You're right about the tests. I'll add them in a separate PR.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

@qimingj
BTW, This PR is actually two commits/PRs, one of which is #714 and another just adds _convert_to_human_name function. I'm following your request to have smaller and more granular PRs. But in case you have a chain of commits, you see all of the previous commits in the PR too.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 24, 2019 •
edited
Loading

/approve

Closes #714 as well

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a53cb58 into kubeflow:master Jan 25, 2019
@Ark-kun Ark-kun mentioned this pull request Jan 25, 2019
Closed
@Ark-kun Ark-kun deleted the SDK/Components---Added-_naming._convert_to_human_name-function branch March 29, 2019 19:45
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi
notebook tests need to use a unique subdirectory (kubeflow#730)
69bab53 
* notebook tests need to use a unique subdirectory

* When the notebook runs on a kubeflow-ci-deployment cluster it will
  upload the rendered notebook to a gcs bucket in kubeflow-ci-deployment.

* We need the GCS path for the notebook to be unique so that results
  from different runs don't overwrite each other.

Related to: kubeflow#715

* Fix subdir.

* Update notebook image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj qimingj approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

@qimingj qimingj

@hongye-sun hongye-sun

Labels
approved area/sdk/components lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @k8s-ci-robot @qimingj @gaoning777 @hongye-sun