feat(backend): isolate artifacts per namespace/profile/user using only one bucket #7725
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| FROM docker.io/minio/mc:RELEASE.2019-08-14T20-49-49Z as minio-cli | ||
|
|
||
| FROM python:3.7 | ||
| # curl -o mc 'https://dl.min.io/client/mc/release/linux-amd64/archive/mc.RELEASE.2019-08-14T20-49-49Z' | ||
| COPY --from=minio-cli /usr/bin/mc /app/mc | ||
| RUN pip3 install 'boto3==1.22.*' 'minio==7.1.*' 'kubernetes==23.3.*' | ||
|
|
||
| ENTRYPOINT ["python3" ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # Change resyncPeriodSeconds to 1 hour from insane 20 seconds | ||
| # For some crazy reasons the crd name is often different... | ||
| # CRD is network-attachment-definitions while the instance is NetworkAttachmentDefinition | ||
| apiVersion: metacontroller.k8s.io/v1alpha1 | ||
| kind: CompositeController | ||
| metadata: | ||
|
|
@@ -27,15 +28,24 @@ spec: | |
| resource: services | ||
| updateStrategy: | ||
| method: InPlace | ||
| - apiVersion: k8s.cni.cncf.io/v1 | ||
| resource: network-attachment-definitions | ||
|
There was a problem hiding this comment. Is this change exclusive to OpenShift cluster? I would suggest creating an overlay to contain this change. There was a problem hiding this comment. It is for any Kubernetes that uses Multus as CNI https://github.com/k8snetworkplumbingwg/multus-cni This change would also affect the python code. Either we leave it in, since it does no harm or we remove it entirely in the composite controller and python code. One could argue that it belongs in the other kubeflow profile controller, so removing it entirely or using overlays as described below is a valid option. |
||
| updateStrategy: | ||
| method: InPlace | ||
| - apiVersion: v1 | ||
| resource: limitranges | ||
| updateStrategy: | ||
| method: InPlace | ||
| - apiVersion: kubeflow.org/v1alpha1 | ||
| resource: poddefaults | ||
| updateStrategy: | ||
| method: InPlace | ||
| - apiVersion: networking.k8s.io/v1 | ||
| resource: networkpolicies | ||
| updateStrategy: | ||
| method: InPlace | ||
| hooks: | ||
| sync: | ||
| webhook: | ||
| url: http://kubeflow-pipelines-profile-controller/sync | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My advice is to install these python library and minio cli client during runtime. New image has to pass license review and has to be served under new registry path. I would avoid that if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could make a runtime check and install them if they are not already there (self-built images), but we need them for the minio configuration. Another option could be to use the minio python client only. Anyway having downloads at runtime makes us dependent on the network and availability of pypi.org and the minio mc download site. I would prefer a static image that always works.
By the way did you read "@zijianjoy The minio mc license was changed quite late minio/mc@1402987 so that should be fine. We are using a way older mc, exactly the same date as your current minio-license-compatible image. The python SDK is still Apache 2.0 https://github.com/minio/minio-py/blob/master/LICENSE.
which minio alternative do you have in mind for the next years? ceph-rook?"
Boto3 is also apache 2.0 https://github.com/boto/boto3/blob/develop/LICENSE together with the kubernetes library https://github.com/kubernetes-client/python/blob/master/LICENSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you were to create a new image, then it needs to be integrated into our test and release process. Here're some pointers on top of my head, there could be more.
https://github.com/kubeflow/pipelines/blob/master/.cloudbuild.yaml
https://github.com/kubeflow/pipelines/blob/master/.release.cloudbuild.yaml