Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to send default service account jwt token for pipeline client. #779

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Feb 5, 2019

This change is Reviewable

@gaoning777
Copy link
Contributor

Does this work for local jupyter notebook accessing a remote K8s cluster?

@hongye-sun
Copy link
Contributor Author

This PR can only send default service account credential to IAP. It should work when the code running in GCE, gke, app engine and cloud function. I just tried it in GKE cluster and it is working fine.

@gaoning777
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member

IronPan commented Feb 9, 2019

/retest

1 similar comment
@IronPan
Copy link
Member

IronPan commented Feb 9, 2019

/retest

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun hongye-sun merged commit 69b7fd3 into kubeflow:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants