SDK/Components/Python - Removed python_op in favor of python_component #85
Conversation
* Added test for python_component + func_to_container_op. * dsl.PythonComponent class is removed, because the metadata is now properly stored in the function object itself. * build_python_component now optionally accepts base_image and no longer requires the decorator (but can use decorator's metadata). * Made staging_gcs_path optional since it's only needed when build_image == True * Added more validation * Added description and parameter help to python_component
Added more detailed explanation of base_image selection to the docstring.
|
/lgtm |
|
@qimingj or @gaoning777 , can you please re-add /lgtm? The robot removed at after I resolved the merge conflict. |
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
Ark-kun
deleted the
avolkov/SDK/Components/Python---Unified-decorators-
branch
* v1.10 should print out the actual service account with RBAC errors rather than obfuscated user id. * This should help debug issues with changes to how we configure kubectl with minikube.
… to 1 (kubeflow#85) * remove annotation and set default timeout * Set resource on container spec * Move in min/max replicas inside model spec * Default scaling target to 1 * Filter built-in annotations and do not propogate * Resolve framework refactor and small fixes * Add license header * Address review comments * Add filter/union function tests
Sync downstream changes to upstream.
chore: Upgrade Argo to v3.4.17 (kubeflow#10978)
Fixes #44
This change is