DataProc commands implementation #862
Conversation
|
/test kubeflow-pipeline-e2e-test |
| )) | ||
|
|
||
| def _dump_cluster(cluster): | ||
| gcp_common.dump_file('/tmp/kfp/output/dataproc/cluster.json', |
There was a problem hiding this comment.
Can we avoid hard-coding any paths inside the library/package? If you want to hardcode them, can you please hardcode them at the component level (in component.yaml) so that they can be fixed/modified without having to change the source code or the container?
There was a problem hiding this comment.
Yes, I have another PR to make the kfp output dir to be configurable. Do you mind if it is sent later than this one?
There was a problem hiding this comment.
Sure. Thank you for doing this. I know that you're not a fan of configurable paths, so I really appreciate what you're doing.
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
* dataproc implementation * Add documentation to dataproc commands. * Add documentation for dataproc commands.
Co-authored-by: kfp-tekton-bot <[email protected]>
It includes commands:
This change is