-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TFX Example.ipynb #913
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Issues when running:
This code works:
|
It's not obvious what kind of input bucket should be put here. There is no connection with the previous |
To prevent exceptions when running the pipeline submission the second time, replace the code with the following:
|
The README.md or notebook do not state that the dataflow needs to be enabled in the cluster.
|
User also needs to configure access:
|
We need to highlight that the user must specify the project ID (which they don't usually see) and not the project name. |
Addressed the ussues discovered here: kubeflow#913
@Ark-kun can you please go ahead and submit a PR with these fixes? |
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the ussues discovered here: kubeflow#913
Addressed the issues discribed here: kubeflow#913
Addressed the issues described here: kubeflow#913
Addressed the issues described here: kubeflow#913
* Improved the TFX OSS notebook and README Addressed the issues described here: #913 * Addressed the PR feedback.
Please add a sample test entry to verify the sample. |
* Improved the TFX OSS notebook and README Addressed the issues described here: kubeflow#913 * Addressed the PR feedback.
Signed-off-by: Theofilos Papapanagiotou <[email protected]>
Adding a notebook for running TFX Example from https://github.com/tensorflow/tfx/tree/master/examples/chicago_taxi_pipeline
This change is