Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests pipelineparam #975

Merged
merged 8 commits into from
Mar 19, 2019
Merged

Add unit tests pipelineparam #975

merged 8 commits into from
Mar 19, 2019
+66 −38

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Mar 15, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777 gaoning777 mentioned this pull request Mar 15, 2019
Merged
@hongye-sun hongye-sun self-assigned this Mar 18, 2019
@hongye-sun
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor Author

gaoning777 commented Mar 18, 2019 •
edited
Loading

/test kubeflow-pipeline-e2e-test

3 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 2accf41 into kubeflow:master Mar 19, 2019
@gaoning777 gaoning777 deleted the add-unit-tests-pipelineparam branch March 19, 2019 01:07
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
fix(sdk): update condition template (kubeflow#975)
66c0944 
eliminate the use of `script`, replace it with
command and args. this also removes the init container that
prepares the script.

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@hongye-sun hongye-sun

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaoning777 @hongye-sun @k8s-ci-robot