Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments for OpenVINO v5 #997

Merged
merged 6 commits into from
Mar 21, 2019
Merged

Adjustments for OpenVINO v5 #997

merged 6 commits into from
Mar 21, 2019

Conversation

dtrawins
Copy link
Contributor

@dtrawins dtrawins commented Mar 19, 2019 •
edited by jlewi
Loading

It includes changes in the exemplary pipeline to include model evaluation with metrics

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from IronPan and vicaire March 19, 2019 22:42
@k8s-ci-robot
Copy link
Contributor

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 20, 2019

/ok-to-test

@gaoning777 What do you think about adding @dtrawins to the OWNERS of the openvino directory?

@vicaire
Copy link
Contributor

vicaire commented Mar 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62c1e12 into kubeflow:master Mar 21, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@chensun
kfp: increase memory limit for metadata-grpc-deployment (kubeflow#997)
72aa365
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@FFede0 @Tomcli
fix(sdk): Support passing directories in step-copy-results-artifacts …
a9f1483 
…and step-copy-artifacts. Fixes kubeflow#996 (kubeflow#997)

* Added support to directories in step-copy-results-artifacts script

Check if the provided result (src) is a directory; if so, create a tar.gz archive and compute the ARTIFACT_SIZE on {src}.tar.gz.
Moreover, print on {dst} file the list of files in {src}.tar.gz (namely, the result of `tar -tzf {src}.tar.gz`) instead of copying directly {src} into {dst}

* Add support to directories in step-copy-artifacts script

Added check [ -d "$2" ] to allow directories to be transmitted as artifacts

* Update unit tests

* Update sdk/python/kfp_tekton/compiler/_data_passing_rewriter.py

Co-authored-by: Tommy Li <[email protected]>

* reducing script size

* generated tests

* removed whitespace identified by lint test

* fixed error (missing suffix)

* generated tests

Co-authored-by: Tommy Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@vicaire vicaire

Labels
approved lgtm ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtrawins @k8s-ci-robot @Ark-kun @vicaire