Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spark-rbac #1986

Merged
merged 4 commits into from
Apr 17, 2024
Merged

fix spark-rbac #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79ab030
remove non-existent field
Aransh Apr 17, 2024
1847128
bump version
Aransh Apr 17, 2024
48f0509
Merge branch 'master' into fix-namespace
Aransh Apr 17, 2024
e0d0882
README
Aransh Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/spark-operator-chart/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: spark-operator
description: A Helm chart for Spark on Kubernetes operator
version: 1.2.9
version: 1.2.10
appVersion: v1beta2-1.4.3-3.5.0
keywords:
- spark
Expand Down
2 changes: 1 addition & 1 deletion charts/spark-operator-chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# spark-operator

![Version: 1.2.9](https://img.shields.io/badge/Version-1.2.9-informational?style=flat-square) ![AppVersion: v1beta2-1.4.3-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.4.3--3.5.0-informational?style=flat-square)
![Version: 1.2.10](https://img.shields.io/badge/Version-1.2.10-informational?style=flat-square) ![AppVersion: v1beta2-1.4.3-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.4.3--3.5.0-informational?style=flat-square)

A Helm chart for Spark on Kubernetes operator

Expand Down
1 change: 0 additions & 1 deletion charts/spark-operator-chart/templates/spark-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ subjects:
roleRef:
kind: Role
name: spark-role
namespace: {{ $jobNamespace }}
Copy link
Contributor

@vara-bonthu vara-bonthu Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewChubatiuk , the support for multiple namespaces was introduced in this commit: GitHub commit link. Have you had a chance to verify if it's working as expected for you? You can also check out the PR raised by @Aransh for more details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not needed, thanks for removing it

apiGroup: rbac.authorization.k8s.io
{{- end }}
{{- end }}
Loading