Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified README.MD as per changes discussed on https://github.com/kubeflow/spark-operator/pull/2062 #2066

Conversation

vikas-saxena02
Copy link
Contributor

@vikas-saxena02 vikas-saxena02 commented Jun 18, 2024

🛑 Important:

This PR is for the change proposed in #2061

Purpose of this PR

The PR aims at providing the new CNCF slack Channel details so that new users can go to new slack channel instead of old slack channel which is going to be archived soon. See details here (#2061)

Proposed changes:

  • Update slack channel to CNCF Slack channel

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Users are currentl joining the old slack channel instead of the new one

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@vikas-saxena02
Copy link
Contributor Author

@vara-bonthu this is the new PR for the changes in README.md
Can you please review this one?

@vikas-saxena02 vikas-saxena02 changed the title Modified README.MD s per changes discussed on https://github.com/kube… Modified README.MDa s per changes discussed on https://github.com/kubeflow/spark-operator/pull/2062 Jun 18, 2024
@vikas-saxena02
Copy link
Contributor Author

@yuchaoran2011 tagging you for a review

@vikas-saxena02 vikas-saxena02 changed the title Modified README.MDa s per changes discussed on https://github.com/kubeflow/spark-operator/pull/2062 Modified README.MD as per changes discussed on https://github.com/kubeflow/spark-operator/pull/2062 Jun 18, 2024
@vikas-saxena02
Copy link
Contributor Author

closes #2061

@vikas-saxena02
Copy link
Contributor Author

resolves #2061

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d37ac38 into kubeflow:master Jun 18, 2024
7 checks passed
@vikas-saxena02 vikas-saxena02 deleted the issue2061_add_new_slack_channel_details branch June 18, 2024 17:16
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants