-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: build operator image as non-root #2171
Conversation
0844cd8
to
cc75df7
Compare
Signed-off-by: ImpSy <[email protected]>
cc75df7
to
9a9de46
Compare
@ImpSy Thanks for the effort to improve the security of operator image! LGTM, will wait for another approval @vara-bonthu @jacobsalway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Nice work @ImpSy 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015, vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ImpSy <[email protected]> (cherry picked from commit e2cc295)
Signed-off-by: ImpSy <[email protected]> (cherry picked from commit e2cc295)
Signed-off-by: ImpSy <[email protected]> (cherry picked from commit e2cc295)
Purpose of this PR
Reduce the permission of the docker image by making it non-root (like the spark image it's build from)
Proposed changes:
setcap
on the binary to keep the ability to mount port <1024 (useful for people mounting webhook on 443)Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
If we aim to increase security of the project, making the image non root is a good 1st step
Checklist
Before submitting your PR, please review the following:
Additional Notes
This change has been live on our product for more than 6 month
You can find the PR from our fork here -> https://github.com/spotinst/spark-on-k8s-operator/pull/10/files