Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement workflow to scan latest released docker image #2177

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ImpSy
Copy link
Contributor

@ImpSy ImpSy commented Sep 17, 2024

Purpose of this PR

Following discussion on this issue #2169
This PR add image scanning using trivy

Proposed changes:

  • add new github workflow to scan latest released image

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

I've run this action on my fork and it returned error to the Security tab correctly -> https://github.com/spotinst/spark-on-k8s-operator/actions/runs/10903921403/job/30259104130

@ChenYi015
Copy link
Contributor

@ImpSy Thanks for the contribution! LGTM, will wait for another approval @yuchaoran2011 @vara-bonthu @jacobsalway .

@jacobsalway
Copy link
Member

jacobsalway commented Sep 18, 2024

Did a test run from my work and it looks good to me, however it seems like Mediums and Lows are still being uploaded to the Security tab. Is this expected or do we need to dig into this more? Not a blocker for me since we can just filter to Critical and High when looking at the results.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 59a8ca4 into kubeflow:master Sep 18, 2024
12 checks passed
tcassaert pushed a commit to tcassaert/spark-operator that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants