Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto deploy to be runnable on kubeflow-ci. #294

Merged
merged 12 commits into from
Jan 30, 2019

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Jan 28, 2019

Remaining tasks:

  • Add github repos (kubeflow/testing) version snapshot.
  • Dockerfile dependencies clean up.
  • Deployed clusters labeling (used to identify the time deployment is made)
  • Add service account role bindings garbage collection to workflow.
  • Add a workflow to create git PR.

This change is Reviewable

@gabrielwen
Copy link
Contributor Author

Relates to #95

@gabrielwen
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Jan 29, 2019

Thanks.

nit: Would you mind updating the PR with comments explaining what changes were needed.

@gabrielwen
Copy link
Contributor Author

Changes include:

  • Move workflows args from Dockerfile to cronjob config. This way we don't need to rebuild the whole image for args.
  • disentangle worker instantiation with github repos. Worker init process is generic enough that we should not need to change it often - Just pull fresh copy of kubeflow and testing repo and start create_kf_instance. This way we also don't need to rebuild worker image when we need to push out a new version - worker uses the what's on Github.
  • Disable deployment deletion. Need to figure out if it's needed and permissions to run it.

@gabrielwen
Copy link
Contributor Author

Thanks.

nit: Would you mind updating the PR with comments explaining what changes were needed.

Added :)

@gabrielwen
Copy link
Contributor Author

/retest all

@jlewi
Copy link
Contributor

jlewi commented Jan 30, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8e3b8f7 into kubeflow:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants