Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snapshot files to checkout repositories. #298

Merged
merged 4 commits into from
Jan 31, 2019

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Jan 31, 2019

Relates to #95

This part uses output of #297 and checkout source codes from Github for deployment.


This change is Reviewable

@gabrielwen
Copy link
Contributor Author

/assign @jlewi

@kunmingg
Copy link
Contributor

Do you need to do git config user.email?
otherwise
/lgtm

@gabrielwen
Copy link
Contributor Author

Do you need to do git config user.email?
otherwise
/lgtm

ran and it works. I think you only need to mention user.email if you clone with SSH?

@kunmingg
Copy link
Contributor

Got it
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7aaff95 into kubeflow:master Jan 31, 2019
@gabrielwen gabrielwen deleted the checkout-script branch February 1, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants