Fix RBAC

Signed-off-by: Andrey Velichkevich <[email protected]>
kubeflow · Jan 21, 2025 · ef67ca8 · ef67ca8
1 parent 2db5829
commit ef67ca8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/manifests/v2/base/rbac/role.yaml b/manifests/v2/base/rbac/role.yaml
@@ -8,14 +8,6 @@ rules:
   - ""
   resources:
   - configmaps
-  verbs:
-  - create
-  - get
-  - list
-  - watch
-- apiGroups:
-  - ""
-  resources:
   - secrets
   verbs:
   - create

diff --git a/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml b/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml
@@ -1,4 +1,4 @@
-# TODO (andreyvelich): Change this to DeepSpeed or MLX runtimes
+# TODO (andreyvelich): Change this to DeepSpeed or MLX runtime.
 apiVersion: kubeflow.org/v2alpha1
 kind: ClusterTrainingRuntime
 metadata:
@@ -23,7 +23,7 @@ spec:
             spec:
               template:
                 spec:
-                  # TODO (andreyvelich): Change the command.
+                  # TODO (andreyvelich): Change the command with mpirun.
                   containers:
                     - name: launcher
                       image: busybox

diff --git a/pkg/runtime.v2/framework/plugins/mpi/mpi.go b/pkg/runtime.v2/framework/plugins/mpi/mpi.go
@@ -61,8 +61,8 @@ var _ framework.ComponentBuilderPlugin = (*MPI)(nil)
 
 const Name = "MPI"
 
-// +kubebuilder:rbac:groups="",resources=secrets,verbs=create;get;list;watch
-// +kubebuilder:rbac:groups="",resources=configmaps,verbs=create;get;list;watch
+// +kubebuilder:rbac:groups="",resources=secrets,verbs=create;get;list;update;watch
+// +kubebuilder:rbac:groups="",resources=configmaps,verbs=create;get;list;update;watch
 
 func New(_ context.Context, client client.Client, _ client.FieldIndexer) (framework.Plugin, error) {
 	return &MPI{