Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xgb yaml container name should be consistent with xgb job default container name #1794

Merged
merged 1 commit into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: kubeflow/lightgbm-dist-py-test:1.0
ports:
- containerPort: 9991
Expand Down Expand Up @@ -44,7 +44,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: kubeflow/lightgbm-dist-py-test:1.0
ports:
- containerPort: 9991
Expand Down
4 changes: 2 additions & 2 deletions examples/xgboost/smoke-dist/xgboostjob_v1_rabit_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
ports:
- containerPort: 9991
Expand All @@ -22,7 +22,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
ports:
- containerPort: 9991
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
ports:
- containerPort: 9991
Expand All @@ -26,7 +26,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
ports:
- containerPort: 9991
Expand Down
4 changes: 2 additions & 2 deletions examples/xgboost/xgboost-dist/xgboostjob_v1_iris_predict.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand All @@ -27,7 +27,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand Down
4 changes: 2 additions & 2 deletions examples/xgboost/xgboost-dist/xgboostjob_v1_iris_train.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand All @@ -29,7 +29,7 @@ spec:
template:
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand All @@ -31,7 +31,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
persistentVolumeClaim:
claimName: xgboostlocal
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
volumeMounts:
- name: task-pv-storage
Expand All @@ -41,7 +41,7 @@ spec:
persistentVolumeClaim:
claimName: xgboostlocal
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
volumeMounts:
- name: task-pv-storage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand All @@ -34,7 +34,7 @@ spec:
kind: Pod
spec:
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
ports:
- containerPort: 9991
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
persistentVolumeClaim:
claimName: xgboostlocal
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
volumeMounts:
- name: task-pv-storage
Expand Down Expand Up @@ -44,7 +44,7 @@ spec:
persistentVolumeClaim:
claimName: xgboostlocal
containers:
- name: xgboostjob
- name: xgboost
image: docker.io/merlintang/xgboost-dist-iris:1.1
volumeMounts:
- name: task-pv-storage
Expand Down