Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] test: add unit tests for delete_job() method #2232

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Bobbins228
Copy link
Contributor

What this PR does / why we need it:
add unit tests for delete_job() method
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Ref: #2161

To verify run:

pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k test_delete_job

Checklist:

  • Docs included if any changes are user facing

@Bobbins228
Copy link
Contributor Author

New PR created following conversation in #2202

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/rerun-all

@andreyvelich
Copy link
Member

Please rebase your PR @Bobbins228.

@Bobbins228 Bobbins228 force-pushed the unit-test-delete-job branch from 97efebd to b12c3c6 Compare August 26, 2024 08:24
@Bobbins228
Copy link
Contributor Author

@andreyvelich both PRs are updated 👍

@andreyvelich
Copy link
Member

@bhupc I think, we need one more rebase since we recently push changes to the training client tests.

@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10667942572

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 31.793%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 10639523457: -0.02%
Covered Lines: 3949
Relevant Lines: 12421

💛 - Coveralls

@Bobbins228
Copy link
Contributor Author

@andreyvelich rebased

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Bobbins228!
Just a few comments from me.

sdk/python/kubeflow/training/api/training_client_test.py Outdated Show resolved Hide resolved
sdk/python/kubeflow/training/api/training_client_test.py Outdated Show resolved Hide resolved
@andreyvelich
Copy link
Member

Thanks for the update @Bobbins228!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c64a5a6 into kubeflow:master Sep 2, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants