-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] test: add unit tests for delete_job() method #2232
[SDK] test: add unit tests for delete_job() method #2232
Conversation
New PR created following conversation in #2202 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/rerun-all
Please rebase your PR @Bobbins228. |
97efebd
to
b12c3c6
Compare
@andreyvelich both PRs are updated 👍 |
@bhupc I think, we need one more rebase since we recently push changes to the training client tests. |
Pull Request Test Coverage Report for Build 10667942572Details
💛 - Coveralls |
b12c3c6
to
1643c5f
Compare
@andreyvelich rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Bobbins228!
Just a few comments from me.
Signed-off-by: Bobbins228 <[email protected]>
1643c5f
to
2bf8130
Compare
Thanks for the update @Bobbins228! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
add unit tests for delete_job() method
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Ref: #2161
To verify run:
Checklist: