Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Go modules #2238

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
hack/swagger/go.mod is outdated. So, I performed go mod tidy.
Additionally, I added a CI command so that we can detect the outdated Go modules in CI.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <[email protected]>
@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10587297012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 31.801%

Totals Coverage Status
Change from base Build 10582250888: 0.02%
Covered Lines: 3950
Relevant Lines: 12421

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ea5272f into kubeflow:master Aug 28, 2024
39 checks passed
@tenzen-y tenzen-y deleted the clean-up-go-module branch August 28, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants