Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for runtimes v2 #2406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akagami-harsh
Copy link

@akagami-harsh akagami-harsh commented Jan 29, 2025

What this PR does / why we need it:

  • added e2e tests for training runtimes v2 using kubernetes golang client

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Your Name <[email protected]>
Signed-off-by: Your Name <[email protected]>
@google-oss-prow google-oss-prow bot requested a review from jinchihe January 29, 2025 18:08
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from kuizhiqing January 29, 2025 18:08
@akagami-harsh akagami-harsh changed the title dd e2e tests for runtimes Add e2e tests for runtimes Jan 29, 2025
@akagami-harsh akagami-harsh changed the title Add e2e tests for runtimes Add e2e tests for runtimes v2 Jan 29, 2025
@akagami-harsh
Copy link
Author

Hey @andreyvelich I have added e2e tests for runtimes v2. Would appreciate your feedback on the test scenarios and structure. Let me know if I'm on the right track!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant