-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Katib: Reorganized Katib Docs #3723
Changes from all commits
3f04681
b8dc907
ccec13c
b839eb4
3fc902a
d26da19
20f98dc
f5913b3
551d9af
c4ed2d6
7333160
63de2d2
4fedc2a
6403ebc
f0311ed
fae7428
616b95c
4bfa56e
52ac8c9
817621a
1435fb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,6 @@ | |
docs/started/requirements/ /docs/started/getting-started/ | ||
|
||
# Created a new components layout | ||
/docs/components/hyperparameter /docs/components/katib/overview | ||
/docs/components/chainer /docs/components/training/chainer | ||
/docs/components/modeldb /docs/components/misc/modeldb | ||
/docs/components/mpi /docs/components/training/mpi | ||
|
@@ -234,3 +233,11 @@ docs/started/requirements/ /docs/started/getting-started/ | |
/docs/distributions/gke/* https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/:splat | ||
/docs/distributions/ibm/* https://ibm.github.io/manifests/ | ||
/docs/distributions/nutanix/* https://nutanix.github.io/kubeflow-manifests/ | ||
|
||
# Refactor Katib docs | ||
/docs/components/hyperparameter /docs/components/katib/overview | ||
/docs/components/katib/hyperparameter /docs/components/katib/getting-started.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @andreyvelich this leads to a 404, because you have put There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great catch, I fixed it: #3733 |
||
/docs/components/katib/experiment /docs/components/katib/user-guides/hp-tuning/configure-experiment | ||
/docs/components/katib/early-stopping /docs/components/katib/user-guides/early-stopping | ||
/docs/components/katib/resume-experiment /docs/components/katib/user-guides/resume-experiment | ||
/docs/components/katib/trial-template /docs/components/katib/user-guides/trial-template |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's usually best to leave the old redirects, as it creates history, and is fine to chain them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesuperzapper I didn't remove the old redirect, I just moved it below:
website/content/en/_redirects
Line 238 in 817621a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyvelich yea, don't do that, as it might break a subsequent redirects that have happened since (if the page has been moved multiple times).
We should only add things to the end of the file. That lets us assume that the current state of the website already has its redirects set up, so we only add new redirects for the actual changes we have made.