Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Archive: version dropdown prefix from v0.4-branch #3867

Merged

Conversation

thesuperzapper
Copy link
Member

This PR is a follow up because #3849 was merged too quickly before we agreed on if the "version dropdown" styling (see: #3863).

This PR makes the following changes:

  • Reverts the addition of the Archive: prefix on the version dropdown.
  • Updates the OWNERS file of this very old branch to align with the current OWNERS in master to make it easier to approve PRs in the future without GitHub admin overrides.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pdmack for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper thesuperzapper changed the title Fix robots/v0.4 branch fix Remove Archive: prefix from v0.4-branch Sep 6, 2024
@thesuperzapper thesuperzapper changed the title Remove Archive: prefix from v0.4-branch @thesuperzapper Remove Archive: version dropdown prefix from v0.4-branch Sep 6, 2024
@thesuperzapper thesuperzapper changed the title @thesuperzapper Remove Archive: version dropdown prefix from v0.4-branch Remove Archive: version dropdown prefix from v0.4-branch Sep 6, 2024
@james-jwu james-jwu merged commit c3b6d0e into kubeflow:v0.4-branch Sep 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants