Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed broken link and surrounding text #3961

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed broken link and surrounding text #3961

wants to merge 2 commits into from

Conversation

pdarshane
Copy link

No description provided.

@google-oss-prow Google OSS Prow
Copy link

Hi @pdarshane. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varodrig
Copy link
Contributor

@pdarshane please update your PR as suggested https://github.com/kubeflow/website/pull/3961/checks?check_run_id=35683252576

@pdarshane pdarshane marked this pull request as draft January 15, 2025 23:28
Arhell
Arhell reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@varodrig
Copy link
Contributor

/ok-to-test

@Arhell is this PR is in draft mode and have issues form the checks. we need to wait for the contributor to make the updates.

@Arhell
Copy link
Member

Arhell commented Jan 16, 2025

/ok-to-test

@Arhell is this PR is in draft mode and have issues form the checks. we need to wait for the contributor to make the updates.

Thank you, I know, for the future

@pdarshane pdarshane marked this pull request as ready for review January 17, 2025 17:03
@google-oss-prow google-oss-prow bot requested a review from zijianjoy January 17, 2025 17:03
varodrig
varodrig approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@varodrig varodrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution

@varodrig
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 19, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: varodrig
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdarshane
Copy link
Author

Hi, zijianjoy, please review. Thanks.

@varodrig
Copy link
Contributor

@andreyvelich can you approve/merge

andreyvelich
andreyvelich reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @pdarshane!

README.md

Whenever any documents reference any source code, you should use the version shortcode in the links, like so:

```
https://github.com/kubeflow/kubeflow/blob/{{< params "githubbranch" >}}/scripts/gke/deploy.sh
```

This ensures that all the links in a versioned webpage point to the correct branch.
This ensures that all the links in a versioned webpage point to the correct branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space here ?

Suggested change
This ensures that all the links in a versioned webpage point to the correct branch.
This ensures that all the links in a versioned webpage point to the correct branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@Arhell Arhell Arhell left review comments

@varodrig varodrig varodrig approved these changes

@jbottum jbottum Awaiting requested review from jbottum

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@varodrig varodrig

Labels
lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdarshane @varodrig @Arhell @andreyvelich