Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate @varodrig to the website reviewers #3970

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

varodrig
Copy link
Contributor

@varodrig varodrig commented Jan 20, 2025

Checklist:

Description of your changes:
Adding user varodrig to the list of reviewers for the website. After creating ~10 PRs, reviewing 100 issues and 80 PRs
over the last 4 months, requesting to be a reviewer following the contributing guide (https://www.kubeflow.org/docs/about/contributing/)

@varodrig
Copy link
Contributor Author

Discussed with @andreyvelich

@varodrig varodrig changed the title Review Adding new reviewer to the website Jan 20, 2025
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to sponsor this, given the significant contributions @varodrig has made to the Kubeflow website!
Thank you for your tremendous effort 🎉
/lgtm
/assign @juliusvonkohout @franciscojavierarceo @kubeflow/kubeflow-steering-committee

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2025
@andreyvelich andreyvelich changed the title Adding new reviewer to the website Nominate @varodrig to the website reviewers Jan 21, 2025
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: franciscojavierarceo, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4e9dab3 into kubeflow:master Jan 21, 2025
6 checks passed
@jbottum
Copy link
Contributor

jbottum commented Jan 21, 2025

great work

@varodrig varodrig deleted the review branch January 21, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants