Azure alternative boot image and some other things (1) #383
Conversation
Allows for alternative boot image for Azure (not only KubeNow image) Fixes download status message in Azure image import script Changes KubeNow_ env prefix to KN_ Adds hcl2json (HashicorpConfigLanguage) to Dockerimage and changes reading of parameters in config file from sed with grep to hcl2json tool Adds private_ip variable to inventory
Allows for alternative boot image for Azure (not only KubeNow image) Fixes download status message in Azure image import script Changes KubeNow_ env prefix to KN_ Adds hcl2json (HashicorpConfigLanguage) to Dockerimage and changes reading of parameters in config file from sed with grep to hcl2json tool Adds private_ip variable to inventory
…now/KubeNow into feature/azure-alternative-bootimage
andersla
changed the title
| @@ -28,19 +28,19 @@ if [ -z "${TF_VARS_FILE}" ]; then | |||
| fi | |||
|
|
|||
| # Get vars from tfvars-file | |||
| arm_client_id=$(grep "client_id" "$TF_VARS_FILE" | | |||
| arm_client_id=$(grep "^client_id" "$TF_VARS_FILE" | | |||
There was a problem hiding this comment.
Isn't it possible to parse with the json2hcl tool?
There was a problem hiding this comment.
I left it as it is because I wanted it to work without Docker image somehow, but I think I changed my mind as well. I will change it for images in a later pull request.
|
|
||
| # Break when finished | ||
| if [[ "$done_bytes" == "$total_bytes" ]]; then | ||
| printf '\rDone copy image \n' | ||
| printf '\rDone copy image \n' |
There was a problem hiding this comment.
Why so many spaces? Can't we have \n straight away?
There was a problem hiding this comment.
It has to overwrite the previous text "Image copy progress: 99% of xxx"
| # Set variables from json-config | ||
| host_cloud=$(jq -r '.provider' <<<"$kn_config") | ||
| image_name=$(jq -r '.boot_image' <<<"$kn_config") | ||
| skip_image_import=$(jq -r '.skip_image_import' <<<"$kn_config") |
There was a problem hiding this comment.
Maybe this should be in the docs as well.
There was a problem hiding this comment.
Skip image import is not set yet, but it is used in a plugin config, where only Terraform part of KubeNow is used and a vanilla image is used.
There was a problem hiding this comment.
The other providers can use an alternative image just specifying the name (together with skip_image_import=true), Only Azure need alternative method in Terraform scripts.
|
Good! Then I think this PR is good to be merged, please add a little bit of documentation on "alternate azure image" and "skip image import" and we are ready to go! |
Change content and motivation
Allows for alternative boot image for Azure (not only KubeNow image)
Fixes download status message in Azure image import script
Changes KubeNow_ env prefix to KN_
Adds hcl2json (HashicorpConfigLanguage2json) to Dockerimage and changes reading of parameters in config file from sed with grep to hcl2json tool
Fixes #316
Fixes #327