Bump Angular to v10, TypeScript to 3.9 and use ESNext

[maciaszczykm]

What this PR does / why we need it: https://volosoft.com/blog/what-is-new-in-angular-10

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2448.

Special notes for your reviewer:

Release note:

NONE

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #2456 into master will decrease coverage by 8.13%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #2456      +/-   ##
==========================================
- Coverage   65.19%   57.06%   -8.14%     
==========================================
  Files         283      283              
  Lines       11589    11165     -424     
  Branches     1460     1443      -17     
==========================================
- Hits         7556     6371    -1185     
- Misses       4022     4783     +761     
  Partials       11       11              

Impacted Files	Coverage Δ
...er-settings/alibaba-provider-settings.component.ts	55.26% <ø> (-6.28%)	⬇️
...ovider-settings/aws-provider-settings.component.ts	55.26% <ø> (-6.28%)	⬇️
...ider-settings/azure-provider-settings.component.ts	50.00% <ø> (-4.72%)	⬇️
...ttings/digitalocean-provider-settings.component.ts	61.29% <ø> (-7.46%)	⬇️
...ovider-settings/gcp-provider-settings.component.ts	61.29% <ø> (-7.46%)	⬇️
...er-settings/hetzner-provider-settings.component.ts	61.29% <ø> (-7.46%)	⬇️
...r-settings/kubevirt-provider-settings.component.ts	61.29% <ø> (-7.46%)	⬇️
...-settings/openstack-provider-settings.component.ts	58.33% <ø> (-6.54%)	⬇️
...er-settings/vsphere-provider-settings.component.ts	52.50% <ø> (-6.04%)	⬇️
...ared/components/event-list/event-list.component.ts	43.13% <0.00%> (-12.64%)	⬇️
... and 248 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f7d1f...6f372ff. Read the comment docs.

[maciaszczykm]

@kgroschoff It seems that I have find solution for the existing issues:

• Font Awesome is now completely removed. It was mainly used to display solid circle (status icon) and loading spinner that were replaced by custom SVGs. There were also 2-3 icons that were replaced by Material Icons.
• ngx-custom-validators had to be reverted to v8.0.0 as it was not working after Angular update.
• Ubuntu font is now installed with fontsource-ubuntu dependency, thanks to it we are not keeping any font assets in our src directory.
• ES5 is no longer supported by Angular 10, I've switched to "esnext" that should allow us to follow the updates.

Please take a look :)

[maciaszczykm]

/test test-e2e

[maciaszczykm]

Build was failing because Subject was imported from rxjs/Subject instead from rxjs directly in a few places. Good to remember for the future.

[kgroschoff]

Nice work 👍

I only noticed one error in the browser console:

Refused to apply style from 'http://localhost:8000/assets/fonts/material_icons/material-icons.css' because its MIME type
('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

Do you also see it?

Otherwise LGTM, couldn't find any other problems 👍

[maciaszczykm]

@kgroschoff It is fixed now. There was a reference to the old file.

[kgroschoff]

Great 😃
/lgtm

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 073ec0acc580e3e680bccd15c605c77fbf963ffd

[kgroschoff]

/hold
not sure if you want to merge other stuff first. feel free to unhold :)

[maciaszczykm]

/retest
/hold cancel