Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.25] Fix default CNI application values in cluster wizard #6887

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[release/v2.25] Fix default CNI application values in cluster wizard #6887

merged 1 commit into from
Sep 26, 2024

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
Manual backport of #6884

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix default CNI application values in cluster wizard.

Documentation:

NONE

@Waseem826 Waseem826 self-assigned this Sep 25, 2024
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@Waseem826
Copy link
Contributor Author

/hold
Should be tested on 2.26 QA first.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@Waseem826
Copy link
Contributor Author

/unhold
Works as expected.
cc @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03263a3ee47c44174294da588b127ea87154e83a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@kubermatic-bot kubermatic-bot merged commit 0c5935a into kubermatic:release/v2.25 Sep 26, 2024
9 of 10 checks passed
@Waseem826 Waseem826 deleted the cherry-pick-6884-to-release/v2.25 branch September 26, 2024 07:46
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Sep 26, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik