Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick default value for KubeLB Gateway API from datacenter #7055

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Pick default value for KubeLB Gateway API from datacenter #7055

merged 1 commit into from
Jan 1, 2025

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jan 1, 2025 •
edited
Loading

What this PR does / why we need it:
For cluster creation, the default value for EnableGatewayAPI and UseLoadbalancerClass will be picked from datacenter configuration.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeLB: enable gateway API and use load balancer class values will now be picked from the datacenter configuration during cluster creation

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 1, 2025
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 1, 2025
@ahmedwaleedmalik ahmedwaleedmalik changed the title Pick default value for KubeLB Gateway API from datacenter{ Pick default value for KubeLB Gateway API from datacenter Jan 1, 2025
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2025
Waseem826
Waseem826 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 1, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 672402202e6b421085e66d180c0fc77691aa66c1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 1, 2025
@ahmedwaleedmalik ahmedwaleedmalik added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/chore Updating grunt tasks etc; no production code changes. labels Jan 1, 2025
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.26

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.26 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot merged commit bb87cb5 into kubermatic:main Jan 1, 2025
8 of 10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.27 milestone Jan 1, 2025
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #7059

In response to this:

/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jan 1, 2025
Merged
@ahmedwaleedmalik ahmedwaleedmalik deleted the gateway-api branch January 18, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.27
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826