Improve docs and naming of LeaderElector methods. (#1468)
#379
k8s-ci-robotAnnotations
10 warnings
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L57
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L136
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L57
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L136
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
src/KubernetesClient/KubernetesException.cs#L87
'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051)
|
|
draft:
src/KubernetesClient/Autorest/HttpOperationException.cs#L61
'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051)
|
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L57
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
src/KubernetesClient/LeaderElection/LeaderElector.cs#L136
Element return value should be documented (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1615.md)
|
|
draft:
tests/KubernetesClient.Classic.Tests/SimpleTests.cs#L15
'DummyHttpServer' contains field 'server' that is of IDisposable type 'TcpListener', but it is never disposed. Change the Dispose method on 'DummyHttpServer' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
draft:
tests/KubernetesClient.Classic.Tests/SimpleTests.cs#L77
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|