-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to net8.0 #1463
Move to net8.0 #1463
Conversation
great, why not move main lib to net8 as well? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1463 +/- ##
=========================================
Coverage ? 69.34%
=========================================
Files ? 89
Lines ? 2652
Branches ? 553
=========================================
Hits ? 1839
Misses ? 811
Partials ? 2 ☔ View full report in Codecov by Sentry. |
I will do it in the next few days |
@tg123 Work done |
/test ? |
@m3nax: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
could you please also bump ver to 12.2 |
@tg123 Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
seems testcases need some upgrade
|
Yes but it is strange that with net 6/7 the exception is System.IO.IOException with 8 is System.Net.Http.HttpIOException, it is a breaking change |
catch HttpIOException | IOExcpetion? |
Looks like we've hit the job timeout... Right? |
@tg123 Why are the compilation and testing actions not started? |
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m3nax, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.Net 8.0 was released, in order to start the migration to the newer version of framework i updated the .net version of examples to the latest. I also accorgitly updated actions to build the update projects.