-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing prometheus-net dependency #1526
Conversation
Welcome @rkarg-blizz! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
=========================================
Coverage ? 62.07%
=========================================
Files ? 102
Lines ? 3014
Branches ? 636
=========================================
Hits ? 1871
Misses ? 1143
Partials ? 0 ☔ View full report in Codecov by Sentry. |
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkarg-blizz, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Metrics are now built in to HttpClient using System.Diagnostics.DiagnosticsSource. https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics-system-net
There are many ways these metrics can be consumed/exposed but that decision is up to the application, not a package like KubernetesClient https://learn.microsoft.com/en-us/dotnet/core/diagnostics/metrics-collection
Closes #1525