Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docfx build #1529

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix docfx build #1529

merged 1 commit into from
Feb 29, 2024

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Feb 28, 2024 •
edited
Loading

use dotnet build -c Release for the build step

action run: https://github.com/WeihanLi/kubernetes-client-csharp/actions/runs/8074136853

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
WeihanLi
WeihanLi commented Feb 28, 2024
View reviewed changes
.github/workflows/docfx.yaml
@@ -34,11 +34,11 @@ jobs:
with:
dotnet-version: |
6.0.x
7.0.x
7.0.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why this diff, seemed no changes, just updated the following build

@tg123
Copy link
Member

tg123 commented Feb 29, 2024

not due to docfx?
last time i checked the pipeline, it was caused by net6 not supported

tg123
tg123 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123, WeihanLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@WeihanLi
Copy link
Contributor Author

not due to docfx?

Seeing this warning, tried with -c Release

https://github.com/kubernetes-client/csharp/actions/runs/8064137407/job/22027395641

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@ce0f192). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1529   +/-   ##
=========================================
  Coverage          ?   62.07%           
=========================================
  Files             ?      102           
  Lines             ?     3014           
  Branches          ?      636           
=========================================
  Hits              ?     1871           
  Misses            ?     1143           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit f78a516 into kubernetes-client:master Feb 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WeihanLi @tg123 @k8s-ci-robot @codecov-commenter