Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1beta1PodDisruptionBudget deserialization should not throw exception on V1beta1PodDisruptionBudgetStatus #466

Closed
edolinina opened this issue Feb 27, 2018 · 10 comments
Closed

V1beta1PodDisruptionBudget deserialization should not throw exception on V1beta1PodDisruptionBudgetStatus #466

edolinina opened this issue Feb 27, 2018 · 10 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@edolinina
Copy link

edolinina commented Feb 27, 2018 •
edited
Loading

create_namespaced_pod_disruption_budget, patch_namespaced_pod_disruption_budget and list_namespaced_pod_disruption_budget throws ValueError("Invalid value for disrupted_pods, must not be None") because it tries to deserialize V1beta1PodDisruptionBudgetStatus model where disruptedPods is mandatory field..
However for V1beta1PodDisruptionBudget object status is optional and not relevant for an example for just created object. Also in V1beta1PodDisruptionBudgetStatus "disruptedPods: null" is valid value
@ceridwen ceridwen mentioned this issue Mar 27, 2018
Open
@soloman817
Copy link

got the same issue...

@roycaihw roycaihw mentioned this issue Jun 13, 2018
Closed
@rvadim
Copy link

rvadim commented Jun 13, 2018

Can we fix this during waiting of fixes in Kuberentes? I can't create proper logic of recreating PDB due to unable to get it.

@roffe
Copy link

roffe commented Aug 13, 2018

same here, just ran in to this trying to automate some creation of PdB's

Rob-Johnson added a commit to Yelp/paasta that referenced this issue Sep 3, 2018
@Rob-Johnson
add a patched version of kubeclient
db9e654 
this is a vendored version of the code at
https://github.com/kubernetes-client/python/blob/master/kubernetes/client/api_client.py

we've vendored it so that we can patch the client and get round
kubernetes-client/python#466 - the patch
prevents an unnecessary check on whether the disruptedpods param passed
to the constructor of V1beta1PodDisruptionBudgetStatus is None (see the
issue comments for confirmation).

I've also made some changes for py3 compatibility
@mydockergit
Copy link

Any idea when this issue will be solved ?

@borqosky
Copy link

workaround from #466 (comment) works also with all objects created from python client needed for create_namespaced_pod_disruption_budget

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 13, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@borqosky @soloman817 @roffe @rvadim @edolinina @k8s-ci-robot @fejta-bot @mydockergit and others