Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift to swagger-codegen version 3.3.3 #692

Closed
seaneagan opened this issue Nov 26, 2018 · 6 comments
Closed

Uplift to swagger-codegen version 3.3.3 #692

seaneagan opened this issue Nov 26, 2018 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@seaneagan
Copy link

seaneagan commented Nov 26, 2018

swagger-codegen v3.3.3:

https://github.com/OpenAPITools/openapi-generator/releases/tag/v3.3.3

added this fix:

OpenAPITools/openapi-generator#1387

which should fix #411 at least in cases where no async calls are made.

this also would address #684.

/cc @007 @micw523

@micw523
Copy link
Contributor

micw523 commented Nov 26, 2018

I would be very careful to make this switch. As you see, the repo you mentioned is not swagger-codegen, but is called OpenApi generator. The repo is maintained by the original codegen authors.

The original codegen repo is now owned by Smartbear and I don’t know if k8s clients have received support from them. It’s difficult to say whether we could make the switch or not. It would be a little more feasible if the original repo contains the bug fix.

@seaneagan
Copy link
Author

I see, I guess that's this PR that is needed then: swagger-api/swagger-codegen#8061

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants