allows null conditions, fixes #415

[rmb938]

No description provided.

[tomplus]

Models are auto-generated by Swagger Codegen and shouldn't be changed in this way.

[rmb938]

Ah. So would removing conditions and acceptedNames from the required block in scripts/swagger.json be acceptable?

"v1beta1.CustomResourceDefinitionStatus": {
      "description": "CustomResourceDefinitionStatus indicates the state of the CustomResourceDefinition",
      "required": [
        "conditions",  <---- remove this?
        "acceptedNames"
      ],
      "properties": {
        "acceptedNames": {
          "description": "AcceptedNames are the names that are actually being used to serve discovery They may be different than the names in spec.",
          "$ref": "#/definitions/v1beta1.CustomResourceDefinitionNames"
        },
        "conditions": {
          "description": "Conditions indicate state for particular aspects of a CustomResourceDefinition",
          "type": "array",
          "items": {
            "$ref": "#/definitions/v1beta1.CustomResourceDefinitionCondition"
          }
        }
      }
    },

[mbohlool]

@rmb938 that could be acceptable and you can do it in preporcessing script in /gen repo. However I would like to see a more generic solution to this, probably by changing OpenAPI spec in the main repo to reflect this for all type of null/empty lists not only CRDs.

[rmb938]

Alright, well do you have any pointers on that? I've never used Swagger for Codegen before so not really sure where to start. My use case is also just with CRDs and creating a more generic solution may become a much larger task,. I am fine with doing that but depending on the size it may make more sense for someone that knows the code base and the backing technologies to get it done much quicker.

[mbohlool]

I would spend time on this if I had any :)

I created kubernetes-client/gen#52 and added what I think a good fix is there. it is very unorganized yet as it is only a brain dump. I will refine it on first free time I got.