-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the README example code more portable #51
Conversation
Also, the `$HOME` variable can be modified while `os.path.expanduser()` does the right thing. This works on windows as well whereas the previous code did not.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
I signed it! |
If this seems sensible, I can change the actual code as well. |
It does make sense. Please change example codes too and let me know when it is ready for review. Thanks for your contribution. |
@mbohlool all you good sir. I figured I could start small contributing to some of the k8s ecosystem projects. Maybe I'll be able to help you grow this project to graduate out of the incubator. |
lgtm |
Also, the
$HOME
variable can be modified whileos.path.expanduser()
does the right thing.This works on windows as well whereas the previous code did not.