Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the README example code more portable #51

Merged
merged 2 commits into from
Dec 1, 2016

Conversation

SEJeff
Copy link
Contributor

@SEJeff SEJeff commented Nov 30, 2016

Also, the $HOME variable can be modified while os.path.expanduser() does the right thing.

This works on windows as well whereas the previous code did not.

Also, the `$HOME` variable can be modified while `os.path.expanduser()` does the right thing.

This works on windows as well whereas the previous code did not.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 30, 2016
@SEJeff
Copy link
Contributor Author

SEJeff commented Nov 30, 2016

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 30, 2016
@SEJeff
Copy link
Contributor Author

SEJeff commented Nov 30, 2016

If this seems sensible, I can change the actual code as well.

@mbohlool
Copy link
Contributor

mbohlool commented Dec 1, 2016

It does make sense. Please change example codes too and let me know when it is ready for review. Thanks for your contribution.

@mbohlool mbohlool self-assigned this Dec 1, 2016
@SEJeff
Copy link
Contributor Author

SEJeff commented Dec 1, 2016

@mbohlool all you good sir. I figured I could start small contributing to some of the k8s ecosystem projects. Maybe I'll be able to help you grow this project to graduate out of the incubator.

@sebgoa
Copy link
Contributor

sebgoa commented Dec 1, 2016

lgtm

@mbohlool mbohlool added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2016
@mbohlool mbohlool merged commit 738dcde into kubernetes-client:master Dec 1, 2016
@mbohlool mbohlool mentioned this pull request Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants