Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codecov.io report and badge #54

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Adding codecov.io report and badge #54

merged 1 commit into from
Dec 2, 2016

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Dec 1, 2016

Adding code coverage report and badge only for Non-Generated packages.

@mbohlool mbohlool added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. no-review-required labels Dec 1, 2016
@mbohlool mbohlool self-assigned this Dec 1, 2016
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2016
@codecov-io
Copy link

codecov-io commented Dec 1, 2016

Current coverage is 93.91% (diff: 100%)

No coverage report found for master at 5677578.

Powered by Codecov. Last update 5677578...2220b7e

@mbohlool mbohlool force-pushed the o7 branch 3 times, most recently from bcd710f to 3624fe7 Compare December 1, 2016 09:55
@mbohlool mbohlool changed the title TEST PR DON'T MERGE Adding codecov.io report and badge Dec 1, 2016
@mbohlool mbohlool added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. no-review-required labels Dec 1, 2016
@mbohlool mbohlool mentioned this pull request Dec 1, 2016
@SEJeff
Copy link
Contributor

SEJeff commented Dec 1, 2016

It might sound weird, but coverage of your tests is good as well. In large testing codebases, you'll find dead code in your tests. Coverage is how you find it and make it die!

@mbohlool
Copy link
Contributor Author

mbohlool commented Dec 1, 2016

Good idea, added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. no-review-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants