-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove services from Sidecar yaml #196
Conversation
Hi @Kartik494. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
assign @jsafrane @vladimirvivien Could you please take a look on this |
/ok-to-test |
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kartik494, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-none |
introduce control variable for non alpha feature gate configuration
What type of PR is this?
What this PR does / why we need it:
Removing Service Spec from sidecar yaml (csi-hostpath-attacher.yaml,csi-hostpath-provisioner.yaml,csi-hostpath-snapshotter.yaml,csi-hostpath-resizer.yaml ) for Kubernetes-1.16,Kubernetes-1.17,Kubernetes-1.18
Which issue(s) this PR fixes:
Fixes #170
Does this PR introduce a user-facing change?: