Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax volume lifecycle checks by default #293

Merged

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 18, 2021

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

The recently introduced "still in use" check revealed a bug in
Kubernetes (kubernetes/kubernetes#101911). While
the check itself is correct, enabling it would cause a lot of test
flakes. Therefore the check has to be disabled until all Kubernetes
versions that we test against are fixed.

Which issue(s) this PR fixes:
Related-to kubernetes/kubernetes#101911

Does this PR introduce a user-facing change?:

Some violations of the volume lifecycle (specifically, VolumeDeleted without NodeUnpublishVolume+NodeUnstageVolume) are not fatal (the behavior in csi-driver-host-path <1.7) and merely cause a warning (new). --check-volume-lifecycle can be used to turn such violations into errors.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2021
The recently introduced "still in use" check revealed a bug in
Kubernetes (kubernetes/kubernetes#101911). While
the check itself is correct, enabling it would cause a lot of test
flakes. Therefore the check has to be disabled until all Kubernetes
versions that we test against are fixed.
@pohly pohly force-pushed the relax-volume-lifecycle-check branch from 75554c0 to 30b4e6a Compare May 18, 2021 12:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2021
@pohly pohly force-pushed the relax-volume-lifecycle-check branch from 6aac6a1 to 30b4e6a Compare May 19, 2021 13:39
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@pohly: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21 30b4e6a link /test pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ca794d into kubernetes-csi:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants